From b81372262c4733e5e8c855674ec5c102843d5b09 Mon Sep 17 00:00:00 2001 From: Laurent Senta Date: Wed, 3 May 2023 11:46:59 +0200 Subject: [PATCH] fix(routing): use explicit opts in test --- coreiface/tests/routing.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/coreiface/tests/routing.go b/coreiface/tests/routing.go index c5486aa72..bf314cafe 100644 --- a/coreiface/tests/routing.go +++ b/coreiface/tests/routing.go @@ -24,17 +24,12 @@ func (tp *TestSuite) TestRouting(t *testing.T) { t.Run("TestRoutingPutOffline", tp.TestRoutingPutOffline) } -func (tp *TestSuite) testRoutingPublishKey(t *testing.T, ctx context.Context, api iface.CoreAPI) iface.IpnsEntry { +func (tp *TestSuite) testRoutingPublishKey(t *testing.T, ctx context.Context, api iface.CoreAPI, opts ...options.NamePublishOption) iface.IpnsEntry { p, err := addTestObject(ctx, api) if err != nil { t.Fatal(err) } - // TODO: make sure we are fine with that implicit allow offline - opts := []options.NamePublishOption{ - options.Name.AllowOffline(true), - } - entry, err := api.Name().Publish(ctx, p, opts...) if err != nil { t.Fatal(err) @@ -108,7 +103,7 @@ func (tp *TestSuite) TestRoutingPutOffline(t *testing.T) { t.Fatal(err) } - ipnsEntry := tp.testRoutingPublishKey(t, ctx, apis[0]) + ipnsEntry := tp.testRoutingPublishKey(t, ctx, apis[0], options.Name.AllowOffline(true)) data, err := apis[0].Routing().Get(ctx, "/ipns/"+ipnsEntry.Name()) if err != nil { t.Fatal(err)