Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix potential crash in unixfs directory #798

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix potential crash in unixfs directory #798

wants to merge 3 commits into from
+22 −8

Conversation

gammazero
Copy link
Contributor

Fix potential crash in sizeBelowThreshold when modifying children in a directory.

Closes #675

@gammazero gammazero requested a review from a team as a code owner January 20, 2025 20:06
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.50%. Comparing base (bcf475c) to head (9256fbe).

Files with missing lines Patch % Lines
ipld/unixfs/io/directory.go 72.22% 4 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   60.49%   60.50%           
=======================================
  Files         245      245           
  Lines       31124    31134   +10     
=======================================
+ Hits        18830    18837    +7     
- Misses      10615    10619    +4     
+ Partials     1679     1678    -1
Files with missing lines Coverage Δ
ipld/unixfs/io/directory.go 68.94% <72.22%> (+0.03%) ⬆️

... and 13 files with indirect coverage changes

@gammazero gammazero changed the title fix potential crahs in unixfs directory fix potential crash in unixfs directory Jan 20, 2025
@gammazero gammazero force-pushed the fix-sizebeloadthreshold branch from 88864ce to 53980fa Compare January 21, 2025 04:41
@gammazero
Copy link
Contributor Author

Needs test

@gammazero
fix potential crahs in unixfs directory
c64639c 
Fix potential crash in sizeBelowThreshold when modifying children in a directory.

Closes #675
@gammazero
update changelog
4369667
@gammazero gammazero force-pushed the fix-sizebeloadthreshold branch from 53980fa to b634709 Compare January 21, 2025 06:36
@gammazero gammazero force-pushed the fix-sizebeloadthreshold branch from b634709 to 9256fbe Compare January 21, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in sizeBelowThreshold
1 participant
@gammazero