gateway: disable Suborigins as it conflicts the spec #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
|
To fix the code coverage it's okay to just comment or remove the code in question. We have revision control and the new code will look different anyhow :) |
|
Yeah, I will just remove it. |
The Suborigins spec was changed and we have to adjust, the spec is still unstable and it might change in future. Currently the only browser supporting it (Chrome) errors out on it as it doesn't confront spec it uses. See ipfs/specs#131 License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
fix/gateways/suborigins-off
branch
from
44b27ea to
912a972
Compare
ghost
added this to the 
whyrusleeping
approved these changes
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Suborigins spec was changed and we have to adjust, the spec is still
unstable and it might change in future. Currently the only browser
supporting it (Chrome) errors out on it as it doesn't confront spec it
uses.
See ipfs/specs#131
Part of #3209
Proper solution requires: deciding on suborigin prefix, propagating go-multibase changes and exposing cid.EncodeWithBase.
We can do that but I would want this to be fixed in 0.4.5 and we want to release very soon.
License: MIT
Signed-off-by: Jakub Sztandera [email protected]