-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to new cbor lib #29
Comments
This lib could be also used for serialization of dagNodes (currently ipld modules are hard-coded with cc @Stebalien |
Missing pieces:
|
Note: some quick benchmarking shows that the current library is slightly faster (especially when decoding). However, that may change when decoding/encoding directly to a datastructure rather than an object. |
Checking on status here. This is still WIP? |
Yes but it's getting close. I need to review and merge some CID changes (so we'll always just use |
That is great news :)
Cheers Friedel
…On 10. Sep 2018, 18:26 -0700, Steven Allen ***@***.***>, wrote:
Yes but it's getting close. I need to review and merge some CID changes (so we'll always just use cid.Cid instead of *cid.Cid). Then, we'll need to update the refmt version here and we should be good to go.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Done. |
We should use https://github.com/polydawn/refmt, it was designed with a lot of our usecases in mind
The text was updated successfully, but these errors were encountered: