This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Feat/pin #15
Closed
Feat/pin #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that verify that the go and js ipfs implementations behave the same when adding/removing pins to the datastore. I've found that they produce essentially the same pinsets with the exception of some ordering. There are a few tangential differences that I've noticed such as fresh go repos include the readme files as pinned while the js impl does not. Draft ipfs#2 coming up! Lots of code dedupe
…'s pinning init-docs.
…removed unused fixtures.
ghost
assigned 
…e through both daemons to a withDaemons command.
6 tasks
|
@JonKrone ipfs-inactive/js-ipfs-http-client#700 needs your attention to finish this endeavor :) |
|
Closing in favor of #19 which is from a branch from ipfs instead of a personal fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js-ipfs is close to finishing work on the pin command: ipfs/js-ipfs#1249.
This suite of tests should give us some confidence that our implementations are compatible and that, to the extent that go's pins are, js-ipfs' are correct.
Depends on:
js-ipfsd-ctldaemons spawning on top of existing repos.I understand that this repo in general has problems with test complexity. I didn't quite run into the complexity of many daemon combinations with this feature as most daemons are spawned in parallel and their output compared. With this and @dryajov's #6 nice, config-based approach, I hope that these tests can help us determine a test api that can transfer across these domains.
Looking forward to comments!