Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS Everywhere in EASE mode blocks redirect to http://*.localhost #855

Open
lidel opened this issue Mar 27, 2020 · 3 comments
Open

HTTPS Everywhere in EASE mode blocks redirect to http://*.localhost #855

lidel opened this issue Mar 27, 2020 · 3 comments
Labels
area/firefox Issues related to Mozilla Firefox

Comments

@lidel
Copy link
Member

lidel commented Mar 27, 2020

There is an Encrypt All Sites Eligible (EASE) opt-in mode in HTTPS Everywhere which protects users against downgrade from https:// to http:// even when HSTS header is not present.

Problem

This is a minor inconvenience for DNSLink redirects to *.localhost subdomains introduced in #853, as those get blocked if the feature is enabled:

HTTPS-Everywhere-EASE-mode-2020-03-27--12-34-08

HTTPS-Everywhere-2020-03-27--12-33-20

Solution

  • Before starting work, check if the issue is limited to Firefox
    • if so, this may go away when Firefox marks *.localhost as Secure Context (Bug 1220810), but that depends on how HTTPS Everywhere determines "unsafe" redirect (won't help if they just look at URL.protocol scheme, and not if URL.origin is Secure Context)
  • Universal fix: PR HTTPS Everywhere to exclude redirects to *.localhost as browser vendors hardcode it to point at loopback IP and mark it as Secure Context
@Mikaela
Copy link
Contributor

Mikaela commented May 5, 2020

This appears to also affect Firefox's new HTTPS-only mode (dom.security.https_only_mode;true), I was hoping that Firefox 76 might also have fixed the aforementioned Consider hardcoding localhost names to the loopback address, but that doesn't seem to be the case.

@thibaultmol
Copy link

Any plans on fixing this? It's still causing issues. (or a workaround)

@Mikaela
Copy link
Contributor

Mikaela commented Feb 17, 2021

I think this may be fixed or at least Firefox's own HTTPS-only mode I mentioned in my last comment doesn't seem to cause issues with IPFS browsing anymore. Firefox's Bug 1220810 (let-localhost-be-localhost) has also been closed 4 months ago.

Links I tested include http://ipfs.io.ipns.localhost:8080/ ("IPFS powers the Distributed Web" and http://http.badssl.com/ ("HTTPS-only mode warning: Protected connection is not available" (translated from Finnish)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/firefox Issues related to Mozilla Firefox
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

4 participants