Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitswap Improvements Landed in js-ipfs? #424

Open
christroutner opened this issue Dec 26, 2021 · 1 comment
Open

Bitswap Improvements Landed in js-ipfs? #424

christroutner opened this issue Dec 26, 2021 · 1 comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@christroutner
Copy link

This issue is an extension of this discussion forum thread. In that thread, I document a high percentage (85%) of data received by a node is redundant, duplicate data.

This Issue in go-ipfs introduces improvements that reduce this duplicate data. It appears to have landed in the go-ipfs implementation.

Has this code landed in js-ipfs? If so, can someone provide a link to the commit? If not, are there any plans or open Issues about it? I might try to contribute to helping it land.

I'm running a fork of v0.55.4 of js-ipfs for my own project. If these bitswap improvements have landed in a new version, then I want to update and bring them into my project.

@christroutner christroutner added the need/triage Needs initial labeling and prioritization label Dec 26, 2021
@welcome
Copy link

welcome bot commented Dec 26, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@christroutner
Copy link
Author

Tagging @dirkmc as he's listed as lead maintainer of js-ipfs-bitswap.

@AnthonyAkentiev
Copy link

@dirkmc @christroutner Any info regarding this issue?

@christroutner
Copy link
Author

The topic of the improvements landing, I haven't gotten any updates.

I ended up my software stack from js-ipfs to go-ipfs, controlling an external node with ipfs-http-client. I was able to take advantage of all the latest optimizations that way.

@welcome

This comment was marked as resolved.

@lidel lidel transferred this issue from ipfs/js-ipfs Mar 11, 2022
@lidel lidel added help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature exp/expert Having worked on the specific codebase is important P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

3 participants