Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Replace manual traversal with ipfs.resolve #14

Open
lidel opened this issue Jan 15, 2019 · 0 comments
Open

Replace manual traversal with ipfs.resolve #14

lidel opened this issue Jan 15, 2019 · 0 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Jan 15, 2019

AFAIK at the time this project was created ipfs.resolve was not present in js-ipfs, and we had to do the traversal manually.

Since then ipfs.resolve landed in js-ipfs so this may be worth checking.

// TODO: replace below with ipfs.resolve(path, {recursive: true})
// (requires changes to js-ipfs/js-ipfs-api)

Things to check:

  • does resolve work the same in go-ipfs and js-ipfs (eg. how HAMT directories are handled)
  • it should transparently take care of sharded directories
@vasco-santos vasco-santos added help wanted Seeking public contribution on this issue status/ready Ready to be worked exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up labels Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants