This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Remove dependency on IPFS #24
Assignees
Comments
achingbrain
added a commit
that referenced
this issue
Nov 8, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
ghost
assigned
achingbrain
added a commit
that referenced
this issue
Nov 8, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
achingbrain
added a commit
that referenced
this issue
Nov 8, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
achingbrain
added a commit
that referenced
this issue
Nov 8, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
achingbrain
added a commit
that referenced
this issue
Nov 8, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
achingbrain
added a commit
that referenced
this issue
Nov 8, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
achingbrain
added a commit
that referenced
this issue
Nov 12, 2018
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We pass in and instance of
js-ipfsto all core modules in this repo but all MFS operations could just usejs-ipldandjs-interface-datastoredirectly instead.We should refactor the core to accept these as arguments instead and so remove the circular dependency of
js-ipfs->js-ipfs-mfs->js-ipfs.The text was updated successfully, but these errors were encountered: