Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: support -p flag on cp #56

Merged
merged 2 commits into from
Jul 18, 2019
Merged

feat: support -p flag on cp #56

merged 2 commits into from
Jul 18, 2019

Conversation

achingbrain
Copy link
Collaborator

This was missed.

@achingbrain achingbrain requested review from alanshaw and dirkmc July 12, 2019 12:23
dirkmc
dirkmc reviewed Jul 12, 2019
View reviewed changes
Copy link

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, my only suggestion would be to put the common code in a function

alanshaw
alanshaw approved these changes Jul 12, 2019
View reviewed changes
Copy link

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achingbrain achingbrain merged commit 0743d90 into master Jul 18, 2019
@achingbrain achingbrain deleted the support-p-flag-on-cp branch July 18, 2019 09:43
@snyk-bot snyk-bot mentioned this pull request Mar 26, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkmc dirkmc dirkmc left review comments

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @alanshaw @dirkmc