-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass backwards-compatible level-js options #215
Conversation
Hm, this was actually intended to maintain backwards compatibility. Because before
In addition, |
@jacobheun if you're happy with this could you please release it & backport it to 0.29.x so we can do a patch release for [email protected] and fix ipfs/js-ipfs#2629? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: pass backwards-compatible level-js options * fix: fix options test * fix: configure datastore prefix and get right level version
* fix: pass backwards-compatible level-js options * fix: fix options test * fix: configure datastore prefix and get right level version
Between
level-js@2
andlevel-js@4
it started passing version numbers intoindexedDB.open
so we have to specify these now. It also prefixes locations with a disambiguator, which we need to set to blank for browsers to still be able to read their previously created databases.Depends on:
[ ] chore: update deps #217