This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
Adds call to progress bar function #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a call to an optional function that can be passed to `Importer`. This will be called with the byteLength of a file's buffered chunk.
daviddias
reviewed
Sep 1, 2017
src/builder/builder.js
Outdated
| @@ -93,7 +93,10 @@ module.exports = function (createChunker, ipldResolver, createReducer, _options) | |||
| pull( | |||
| file.content, | |||
| createChunker(options.chunkerOptions), | |||
| pull.map(chunk => new Buffer(chunk)), | |||
| pull.map(chunk => { | |||
| if (options.progress) options.progress(chunk.byteLength) | |||
There was a problem hiding this comment.
Should check that it is also a function
This commit also updates the readme.md file with a discription for how to use this option.
daviddias
suggested changes
Sep 4, 2017
in some of my tests I was writing ``` expect(someTrueValue).to.be.true ``` but this is an `unused-expressions` in the eyes of eslint. So the work around is to just `expect(someTrueValue).to.equal(true)`.
daviddias
approved these changes
Sep 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a call to an optional function that can be passed to
Importer.This will be called with the byte length of a file's buffered chunk.
The idea is you can pass a function into the Importer and have that function called as a step in the pull stream that creates and stores a file/files.