This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
Adds begin/end byte slices to exporter #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Mar 21, 2018
achingbrain
force-pushed
the
consolidate-readable
branch
from
7bb47ff to
6325db9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've flip-flopped slightly on #202 - I think it would be better to add the
begin/endarguments to the existingexporterinstead of introducing the newreadermodule as the new module increases the API surface area while not handling as manyipfsPathedge cases as theexporterso is consequently less useful and also harder to reason about.This PR removes the
readerand adds the stream slicing logic to theexporterinstead. It preserves the tests added as part of #202.