Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: update dependencies #1473

Merged
merged 5 commits into from
Jul 28, 2018
Merged

chore: update dependencies #1473

merged 5 commits into from
Jul 28, 2018

Conversation

alanshaw
Copy link
Member

No description provided.

@ghost ghost assigned alanshaw Jul 27, 2018
@ghost ghost added the status/in-progress In progress label Jul 27, 2018
@olizilla
Copy link
Member

@alanshaw @diasdavid Getting this in would release the fix for the "already piped" errors, that you get when you leave a js-ipfs node running for a while. https://github.com/libp2p/js-libp2p-switch/issues/235

There are 28 days of other libp2p updates behind that version increment, so we'd need to run all the third party app tests again to feel confident there are no surprises, but you know, ONLY FORWARDS!

cc @jacobheun

daviddias
daviddias approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take in consideration @olizilla's comment, but fixing the already piped errors does sound really great to me!

@daviddias
Copy link
Member

This one keeps appearing.

  1) ping DHT disabled "before all" hook:

     Error: Error: A node cannot dial itself

      at parseError (node_modules/ipfs-api/src/utils/send-request.js:17:17)

      at ClientRequest.<anonymous> (node_modules/ipfs-api/src/utils/send-request.js:47:14)

      at ClientRequest.EventEmitter.emit (domain.js:442:20)

      at HTTPParser.parserOnIncomingClient (_http_client.js:546:21)

      at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)

      at Socket.socketOnData (_http_client.js:432:20)

      at Socket.EventEmitter.emit (domain.js:442:20)

      at addChunk (_stream_readable.js:283:12)

      at readableAddChunk (_stream_readable.js:264:11)

      at Socket.Readable.push (_stream_readable.js:219:10)

      at TCP.onread (net.js:635:20)

@daviddias daviddias force-pushed the chore/update-deps-20180727 branch from da5e92d to 397eab3 Compare July 28, 2018 07:21
@ghost ghost assigned daviddias Jul 28, 2018
@alanshaw alanshaw changed the title chore: update libp2p and is-ipfs dependencies chore: update dependencies Jul 28, 2018
@daviddias
Copy link
Member

Saw one failure but not related with tests. Jenkins is having a bad day today

image

@daviddias
Copy link
Member

Only test failing now is related with preload


  1) MFS preload should preload MFS root periodically:


      Uncaught AssertionError: expected [ 'QmSame' ] to deeply equal [ 'QmSame', 'QmUpdated' ]

      + expected - actual


       [

         "QmSame"

      +  "QmUpdated"

       ]

      

      at preloader.stop (test/core/mfs-preload.spec.js:48:21)

      at Object.stop (src/core/mfs-preload.js:48:7)

      at Timeout.setTimeout [as _onTimeout] (test/core/mfs-preload.spec.js:43:19)

@daviddias
Copy link
Member

Just missing stuff that is not related with this PR

image

@daviddias daviddias changed the base branch from master to feat/preload-on-fetch July 28, 2018 11:40
@daviddias daviddias merged commit 6fb808d into feat/preload-on-fetch Jul 28, 2018
@daviddias daviddias deleted the chore/update-deps-20180727 branch July 28, 2018 11:40
@ghost ghost removed the status/in-progress In progress label Jul 28, 2018
@alanshaw alanshaw mentioned this pull request Jul 28, 2018
Closed
23 tasks
alanshaw added a commit that referenced this pull request Jul 29, 2018
@alanshaw
feat: preload on content fetch requests (#1475)
649b755 
When JS IPFS requests content not stored locally it needs to ask the peers it knows about to provide it if they have it. The peers are not relays so if they don't have it, they won't find it and provide it to JS IPFS. However, if we issue a preload request prior to these requests we prompt the preload nodes to fetch the content using their DHT and they can then provide it to JS IPFS.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

* chore: update dependencies (#1473)

* chore: update libp2p and is-ipfs dependencies

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

* chore: update all the deps

* fix: rm non used boostrappers from tests

* test: increase mfs preload timeout

* test: pin-set timeout increase

* test: add preload tests for content retrieval

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

* fix: GET request not HEAD

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@alanshaw alanshaw

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @olizilla @daviddias