This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: preload on content fetch requests #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JS IPFS requests content not stored locally it needs to ask the peers it knows about to provide it if they have it. The peers are not relays so if they don't have it, they won't find it and provide it to JS IPFS. However, if we issue a preload request prior to these requests we prompt the preload nodes to fetch the content using their DHT and they can then provide it to JS IPFS. License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
* chore: update libp2p and is-ipfs dependencies License: MIT Signed-off-by: Alan Shaw <[email protected]> * chore: update all the deps * fix: rm non used boostrappers from tests * test: increase mfs preload timeout * test: pin-set timeout increase
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
changed the title
|
CI green! |
|
Put it in a boat 🚣♂️ |
daviddias
approved these changes
Jul 29, 2018
|
Its breaking - possibly breaking one of my demos - see #1476 |
|
We’re waiting on the CORS settings for the preload nodes to be updated. The failing requests are async and should not effect anything else. |
License: MIT Signed-off-by: Alan Shaw <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JS IPFS requests content not stored locally it needs to ask the peers it knows about to provide it if they have it. The peers are not relays so if they don't have it, they won't just go and find it and provide it to JS IPFS.
However, if we issue a preload request prior to these requests we prompt the preload nodes to fetch the content using their DHT and they can then provide it to JS IPFS.
This fixes the story of adding content to go-ipfs and retrieving it from js-ipfs.