This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: mfs preload test #1551
Merged
fix: mfs preload test #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
JS makes no guarantees a function you schedule with `setTimeout` will execute before another function you schedule _even_ if the second function is scheduled for execution _after_ the first. This PR fixes the MFS preload test to wait for the expected CIDs to have been preloaded instead of assuming they would be preloaded after a certain time. License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
fix/preload-test
branch
from
13b4eca to
bee8e3b
Compare
victorb
suggested changes
Sep 11, 2018
| } | ||
|
|
||
| waitFor(test, { name: 'CIDs to be preloaded' }, (err) => { | ||
| expect(err).to.not.exist() |
There was a problem hiding this comment.
rather than expect(err).to.not.exist() we should be using if (err) return done(err) so we properly finish off the test when it errors
There was a problem hiding this comment.
Do you mean so that we always call preloader.stop?
I'm not sure I understand why using done(err) is necessary in this case and not elsewhere in the tests?
|
Ok I'm going to merge this as for now so that we can get other PRs passing. We can fix/update later if needs be. All green except one CI failure, which seems to be a CI issue not an issue with this code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS makes no guarantees a function you schedule with
setTimeoutwill execute before another function you schedule even if the second function is scheduled for execution after the first.This PR fixes the MFS preload test to wait for the expected CIDs to have been preloaded instead of assuming they would be preloaded after a certain time.