This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: only dial to unconnected peers #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
reviewed
Mar 12, 2019
License: MIT Signed-off-by: Alan Shaw <[email protected]>
When we discover a peer, we may not have the latest information from our PeerBook, such as the connected multiaddress. Doing peerBook.put handles merging this information and the new PeerInfo instance is returned. Updating the peerInfo instance, before performing a check, should make sure we have the correct information. Co-Authored-By: alanshaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
fix/only-dial-unconnected
branch
from
9abf468 to
540e10c
Compare
vasco-santos
approved these changes
Mar 13, 2019
jacobheun
approved these changes
Mar 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: