This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: cat deeply nested file #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exporter was exporting the file, but the filter was filtering it out because the exported path includes only `file.txt` but the filter was expecting `path/file.txt`. So when you cat `/ipfs/QmHash/file.txt` it worked, but when you cat `/ipfs/QmHash/path/file.txt` it did not. License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
|
Merging because the CI error is unrelated: 1) cli
dht
query:
Error: Command failed: /Users/travis/build/ipfs/js-ipfs/src/cli/bin.js dht query QmRhsb2HQUGSrZstoMqiYunqgDzw566igxtgdTwxbgrGuQ
connect ECONNREFUSED 127.0.0.1:52581
at makeError (node_modules/execa/index.js:174:9)
at Promise.all.then.arr (node_modules/execa/index.js:278:16)
at process._tickCallback (internal/process/next_tick.js:68:7) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter was exporting the file, but the filter was filtering it out because the exported path includes only
file.txtbut the filter was expectingpath/file.txt.So when you cat
/ipfs/QmHash/file.txtit worked, but when you cat/ipfs/QmHash/path/file.txtit did not because the exported file had pathfile.txtbut the filter was looking forpath/file.txt.Depends on: