Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: name resolve arg parsing #1958

Merged
merged 1 commit into from
Mar 21, 2019
Merged

fix: name resolve arg parsing #1958

merged 1 commit into from
Mar 21, 2019

Conversation

alanshaw
Copy link
Member

Boolean args were not being parsed as booleans.

fix: name resolve arg parsing
b82ce39 
Boolean args were not being parsed as booleans.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@ghost ghost assigned alanshaw Mar 21, 2019
@ghost ghost added the status/in-progress In progress label Mar 21, 2019
jacobheun
jacobheun approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Windows CI, this looks good. I also verified this locally. 🚀

@alanshaw alanshaw merged commit 924690e into master Mar 21, 2019
@alanshaw alanshaw deleted the fix/name-resolve-test branch March 21, 2019 22:15
@ghost ghost removed the status/in-progress In progress label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

Assignees

@alanshaw alanshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @jacobheun