-
Notifications
You must be signed in to change notification settings - Fork 1.2k
files ls #1073
Conversation
@pgte make sure to rebase master onto this branch, there were some fixes there that will affect how your tests run (not your codebase though :)) |
License: MIT Signed-off-by: Rasmus Erik Voel Jensen <[email protected]>
Depends on
|
@@ -13,6 +13,7 @@ const waterfall = require('async/waterfall') | |||
const isStream = require('is-stream') | |||
const Duplex = require('stream').Duplex | |||
const CID = require('cids') | |||
const toB58String = require('multihashes').toB58String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use new CID(hash).toBaseEncodedString()
instead
src/http/api/routes/files.js
Outdated
api.route({ | ||
// TODO fix method | ||
method: '*', | ||
path: '/api/v0/files/ls', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be just /api/v0/ls
CI failed because of missing linting https://travis-ci.org/ipfs/js-ipfs/jobs/301842793#L2971-L2973 I'm fixing it |
I just got fresh code from master and it appears that
|
@richardschneider This implemented
We want to converge all of them, step by step :) |
Based on #940 and ipfs-inactive/js-ipfs-unixfs-engine#197
ipfs.files.ls
andipfs.ls
files ls
andls
alias