This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reduces the umber of bits for the Peer ID generated in bitswap CLI tests. License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned alanshaw
Sep 5, 2018
vasco-santos
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Preload tests have been failing with timeout
several times! Thanks for increasing them
Calls back when async func returns true. License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
changed the title
chore: increase preload test timeouts
chore: more test stabalization
Sep 6, 2018
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
chore/increase-preload-test-timeouts
branch
from
September 6, 2018 10:11
0aa2c4d
to
267b456
Compare
alanshaw
changed the title
chore: more test stabalization
chore: more test stabilization
Sep 6, 2018
License: MIT Signed-off-by: Alan Shaw <[email protected]>
daviddias
reviewed
Sep 15, 2018
"test:node:http": "aegir test -t node -f test/http-api/index.js --timeout=10000", | ||
"test:node:gateway": "aegir test -t node -f test/gateway/index.js --timeout=10000", | ||
"test:node:cli": "aegir test -t node -f test/cli/index.js --timeout=10000", | ||
"test:bootstrapers": "IPFS_TEST=bootstrapers aegir test -t browser -f test/bootstrapers.js --timeout=10000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to avoid global timeouts and instead focus on understanding which tests are actually timing out by seeing the explicit this.timeout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitFor
utility to wait for an async function to return true before continuing