Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: more test stabilization #1541

Merged
merged 11 commits into from
Sep 7, 2018
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Sep 5, 2018

  • Increases the preload test timeouts
  • Reduces the number of bits for the Peer ID generated in bitswap CLI tests
  • Adds waitFor utility to wait for an async function to return true before continuing
  • Ensures temp repos are cleaned up after tests
  • Increases default test timeout from 5s to 10s

Also reduces the umber of bits for the Peer ID generated in bitswap CLI tests.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@ghost ghost assigned alanshaw Sep 5, 2018
@ghost ghost added the status/in-progress In progress label Sep 5, 2018
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Preload tests have been failing with timeout several times! Thanks for increasing them

Calls back when async func returns true.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@alanshaw alanshaw changed the title chore: increase preload test timeouts chore: more test stabalization Sep 6, 2018
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@alanshaw alanshaw force-pushed the chore/increase-preload-test-timeouts branch from 0aa2c4d to 267b456 Compare September 6, 2018 10:11
@alanshaw alanshaw changed the title chore: more test stabalization chore: more test stabilization Sep 6, 2018
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@alanshaw alanshaw merged commit db703b9 into master Sep 7, 2018
@ghost ghost removed the status/in-progress In progress label Sep 7, 2018
@alanshaw alanshaw deleted the chore/increase-preload-test-timeouts branch September 10, 2018 11:06
"test:node:http": "aegir test -t node -f test/http-api/index.js --timeout=10000",
"test:node:gateway": "aegir test -t node -f test/gateway/index.js --timeout=10000",
"test:node:cli": "aegir test -t node -f test/cli/index.js --timeout=10000",
"test:bootstrapers": "IPFS_TEST=bootstrapers aegir test -t browser -f test/bootstrapers.js --timeout=10000",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to avoid global timeouts and instead focus on understanding which tests are actually timing out by seeing the explicit this.timeout

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants