This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a `jsipfs cid` command with tools for formatting, converting and discovering properties of CIDs. All the docs are here: https://github.com/ipfs-shipyard/js-cid-tool Will resolve this for JS: ipfs/kubo#5229 go-ipfs counterpart: ipfs/kubo#5385 License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
feat/cid-tool
branch
from
October 16, 2018 07:42
b3cb736
to
19eb126
Compare
@diasdavid ipfs/kubo#5385 has now been merged, it would be great to get your review and approval to get this in now 🙏 |
daviddias
approved these changes
Oct 16, 2018
|
||
builder (yargs) { | ||
return yargs | ||
.commandDir(cidCommandsPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woa, this is magic. Running a CLI from another CLI ⚡️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the idea from js-ipfs-mfs ;)
Merging this as the test failure is because of ipfs.io DNS, unrelated to this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
jsipfs cid
command with tools for formatting, converting and discovering properties of CIDs.All the docs are here: https://github.com/ipfs-shipyard/js-cid-tool
Will resolve this for JS: ipfs/kubo#5229
go-ipfs counterpart: ipfs/kubo#5385