Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: crash when using searchParams option #4341

Closed
wants to merge 1 commit into from

Conversation

sk-gachou
Copy link

@sk-gachou sk-gachou commented Apr 6, 2023

This pull attempt to fix the issue when trying to use searchParams option for http client.

According to the doc, one can provide searchParams (an URLSearchParams instance) to add extra query parameters. Currently, this behaviour does not work, see this gist: https://gist.github.com/sk-gachou/2dd253acb1e1663e37119120c2db4768

It crash at this line:
https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-http-client/src/lib/to-url-search-params.js#L42

@welcome
Copy link

welcome bot commented Apr 6, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@achingbrain
Copy link
Member

js-IPFS is in the process of being deprecated, the replacement is Helia - please see the State of IPFS in JS post for a bit of background and the migration guide for how to port your app over.

You're using ipfs-http-client - if you are talking to a Kubo node, please use kubo-rpc-client instead and open any issues there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants