This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add /api/v0/config/show endpoint #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -221,5 +234,15 @@ describe('config', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('ipfs.config.show', () => { | |||
There was a problem hiding this comment.
Was just trying to keep the structure of the other endpoints' tests, removed both of them
|
overall LGTM :) Let's just take out the unnecessary |
fbaiodias
force-pushed
the
feature/http-api-config-show
branch
from
5a35816 to
ca06e29
Compare
|
woot! :D |
daviddias
added a commit
that referenced
this pull request
Feb 28, 2016
Add /api/v0/config/show endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
/api/v0/config/showas specified at ipfs-inactive/http-api-spec#29Related to #49 & very similar to #72