-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better buffering #4280
Comments
I've now tried:
No dice. Nothing makes a difference. The thing is, bitswap doesn't send a lot of little messages (to the same peer). We send a lot of little messages to many peers (buffering won't help) and many large messages to a single peer (buffering won't help). Even if we end up sending the message length in a separate packet/secio-message, that extra message is easily amortized by the size of the primary message in most cases. TL;DR: Dead end. |
I take this back. Adding double buffering (with a small delay) helps reduce the number of packets quite a bit (testing with wireshark). I believe the issues with my prior testing were:
|
Closing in favor of #3155. |
We should add buffering to all of our message-based APIs so we avoid sending message fragments. This should alleviate libp2p/go-libp2p#235.
The text was updated successfully, but these errors were encountered: