Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS UI + HTTPs API are always pointing to port 80 #4488

Closed
koalalorenzo opened this issue Dec 14, 2017 · 6 comments
Closed

IPFS UI + HTTPs API are always pointing to port 80 #4488

koalalorenzo opened this issue Dec 14, 2017 · 6 comments
Assignees

Comments

@koalalorenzo
Copy link
Member

koalalorenzo commented Dec 14, 2017

Version information: 0.4.13

Type: Bug

Severity: Medium

Description:

When I am exposing the API behind a reverse proxy via HTTPS (nginx), the API call coming from the /webui interface are all failing as they are trying to get to port :80. In the logs of the browser it looks like this:

GET https://ipfs-api.myawesomewebsite:80/api...

What should I do to allow the UI to talk to the HTTPS correctly?
If I am disabling HTTPS it works perfectly.

To reproduce you can spin up a container, set up nginx to point :443 to :5001. Even with a fake certificate you will see the problem by browsing to https://localhost/webui.

@Stebalien
Copy link
Member

This has been fixed and will be released in 0.4.14.

@lukecyca
Copy link

It's been over two months since this bug was fixed, and the 0.4.14 milestone is still only 28% complete. Would it be possible to divide the milestone so we can make this fix (and other fixes) available in a release?

@Stebalien
Copy link
Member

So... ignore the milestone, they don't often give any clear indication of blockers. At the moment, we have a few regressions with regards to the recently updated commands library that we'd like to fix before releasing.

However, I agree, we need to get a release out the door ASAP.

@lukecyca
Copy link

lukecyca commented Mar 6, 2018

@Stebalien thanks for the heads up. Do you have an idea when we might see a release containing this fix? Days or weeks or months? No pressure, I just need to decide if I should backport it and make a custom build for myself. Thanks for your help!

@Stebalien
Copy link
Member

We should have an RC out in days. A release in a week, maybe. #4759

@lukecyca
Copy link

I've tested this issue on 0.4.14-rc1 and it doesn't appear to be fully fixed. I'm possibly doing something wrong.

My webui is at https://ipfs.example.com/webui which redirects to https://ipfs.example.com/ipfs/Qm...

However it is attempting to hit the API at http://ipfs.example.com:443/api/v0/...

So the port is correct in a way, but it appears to have "http" hardcoded as the URI scheme, so it doesn't work. Afterall an https server is more than just an http server running on port 443.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants