-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a context to cmds.Request #505
Comments
@whyrusleeping yep, the context should be cancelled if/when the request's connection terminates. |
it's gonna get confusing cause the request already has a context (it's something else atm). |
related: #242 |
this is done. just needs to be wired to more commands ( |
Does this refer to https://github.com/ipfs/go-ipfs/blob/master/core/commands/refs.go#L105? |
@rht not sure, we should go through all of them and make sure all the ctx related thing derive from |
yeah, i recently refactored and made the |
Currently (unless I'm missing something) we have no way of allowing the user to cancel a command. If we add in a context to the request handler it will allow us to have a mechanism to cancel commands with.
The text was updated successfully, but these errors were encountered: