Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config option for specifying full default cidv1 parameters #5230

Open
kyledrake opened this issue Jul 13, 2018 · 4 comments
Open

Create config option for specifying full default cidv1 parameters #5230

kyledrake opened this issue Jul 13, 2018 · 4 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature need/maintainers-input Needs input from the current maintainer(s) topic/cidv1b32 Topic cidv1b32 topic/config Topic config

Comments

@kyledrake
Copy link

Create a config file option to set cidv1 and encoding for output of API / commands.

https://github.com/ipfs/ipfs/issues/337

@kevina

@kevina
Copy link
Contributor

kevina commented Jul 27, 2018

I believe we should have the following options:

  • Default.CidVersion -- the default CID version of newly created hashes
  • Default.CidBase -- the default base to display CIDv1 hashes, CIDv0 hashes are unaffected
  • Default.CidHash -- the default hash to use for newly created hashes if CidVersion > 1

Note that defining Default.CidVersion > 1 also implies the use of raw leaves when applicable.

These are also only defaults. Command line flags will override this so will parent CIDs within the Files API.

The question is should we separate things like Server defaults, Client defaults, and Gateway defaults or is this not worth the trouble?

@kevina
Copy link
Contributor

kevina commented Aug 9, 2018

@whyrusleeping @Stebalien does this sound reasonable to you?

@Stebalien Stebalien mentioned this issue Apr 20, 2020
71 tasks
@RubenKelevra
Copy link
Contributor

RubenKelevra commented Apr 20, 2020

I would love to have the ability to lock down the CID-Version to v1 in 0.5.0, since currently I end up with a some CIDs in v0 and some in v1.

This is quite hard to debug, since there's a breaking change for 0.5.0 which makes the CIDv1 in the DHT incompatible with 0.4.x.

So some requests might fail, while others might work. And if there's a request for a v0 before, you might up ending getting v1 CIDs as well, since bitswap asks directly thru the open connections.

@hsanjuan hsanjuan added topic/config Topic config exp/expert Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature need/maintainers-input Needs input from the current maintainer(s) labels Apr 21, 2020
@ec1oud
Copy link

ec1oud commented May 16, 2021

Why is this not done? Seems like not very much work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature need/maintainers-input Needs input from the current maintainer(s) topic/cidv1b32 Topic cidv1b32 topic/config Topic config
Projects
None yet
Development

No branches or pull requests

6 participants