Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add faster by trusting file modification time (mtime), size and path #5734

Open
futpib opened this issue Nov 4, 2018 · 1 comment
Open
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@futpib
Copy link

futpib commented Nov 4, 2018

Version information:

go-ipfs version: 0.4.17-
Repo version: 7
System version: amd64/linux
Golang version: go1.10.3

Type:

Feature

Description:

When running ipfs add --recursive --nocopy ./huge-dir ipfs rehashes all files, even the ones already added.

This process could be faster with an option to skip already added files unless their mtime or size changed in the underlying filesystem.

Some mtime discussion already happened in #875

@kevina kevina added the kind/enhancement A net-new feature or improvement to an existing feature label Nov 5, 2018
@kevina kevina self-assigned this Nov 5, 2018
@Stebalien
Copy link
Member

We can actually do even better and just ignore any files whose paths are tracked by the filestore (as changing those files will break everything anyways). The tricky part is the interaction with the add command itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants