Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs swarm limit all --reset does not remove user overrides from Swarm.ResourceMgr.Limits #9576

Closed
lidel opened this issue Jan 21, 2023 · 2 comments
Closed

ipfs swarm limit all --reset does not remove user overrides from Swarm.ResourceMgr.Limits #9576

lidel opened this issue Jan 21, 2023 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up topic/commands Topic commands topic/libp2p Topic libp2p topic/resource-manager Issues related to Swarm.ResourceMgr (resource manager)

Comments

@lidel
Copy link
Member

lidel commented Jan 21, 2023 •
edited
Loading

UX problem:
It is impossible to reset all scopes via single CLI/RPC call.
User is forced to list them first, and then remove manually one by one:

$ ipfs swarm limit --help
...
  The scope can be one of the following:
  - all           -- all limits actually being applied.
  - system        -- limits for the system aggregate resource usage.
...

$ ipfs swarm limit all --reset
Error: invalid scope "all"

cc #9417 (but not a hard blocker, we can fix this in 0.19)
@lidel lidel added kind/bug A bug in existing code (including security flaws) topic/libp2p Topic libp2p topic/commands Topic commands P1 High: Likely tackled by core team if no one steps up labels Jan 21, 2023
@lidel lidel mentioned this issue Jan 22, 2023
Closed
@BigLep BigLep moved this to 🥞 Todo in IPFS Shipyard Team Jan 23, 2023
@lidel lidel mentioned this issue Jan 26, 2023
Closed
1 task
@ajnavarro
Copy link
Member

Possible alternative solution #9603

@BigLep BigLep mentioned this issue Jan 31, 2023
Closed
@lidel lidel added the topic/resource-manager Issues related to Swarm.ResourceMgr (resource manager) label Feb 14, 2023
@BigLep
Copy link
Contributor

BigLep commented Feb 16, 2023

Agreed that we'll do #9603 which neutralizes the need to solve this. I'm closing this as won't fix.

@BigLep BigLep closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up topic/commands Topic commands topic/libp2p Topic libp2p topic/resource-manager Issues related to Swarm.ResourceMgr (resource manager)
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BigLep @lidel @ajnavarro