Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon help docs for CORS #1443

Merged
merged 1 commit into from
Jul 3, 2015
Merged

daemon help docs for CORS #1443

merged 1 commit into from
Jul 3, 2015

Conversation

carver
Copy link

@carver carver commented Jul 3, 2015

Convey the basic idea, plus an example. Don't encourage using *.

This would have saved me some code spelunking.

Convey the basic idea, plus an example.  Don't encourage using `*`.

This would have saved me some code spelunking.
@jbenet jbenet added the backlog label Jul 3, 2015
@GitCop
Copy link

GitCop commented Jul 3, 2015

There were the following issues with your Pull Request

  • Commit: c4fb36b
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@carver
Copy link
Author

carver commented Jul 3, 2015

License: MIT is fine. Do I need to rewrite the commit and force-push?

@jbenet
Copy link
Member

jbenet commented Jul 3, 2015

License: MIT is fine. Do I need to rewrite the commit and force-push?

yes please, see Guidelines

@whyrusleeping
Copy link
Member

this is a feature i did not know we had. 👍

@jbenet
Copy link
Member

jbenet commented Jul 3, 2015

LGTM 👍

@carver bonus points if you make an example for https://github.com/ipfs/examples

@carver
Copy link
Author

carver commented Jul 3, 2015

unfortunately, although exporting this variable did stop the CORS errors, i am still getting a 403 Forbidden from the API server when trying to post some text.

i'm happy to add one to ipfs/examples, but i'll wait until i have the browserified version of ipfs-api working end to end.

i'm also working on node-ipfs-api, adding the CORS info to the readme, and maybe fixing a Buffer bug: Uncaught Error: File.contents can only be a Buffer, a Stream, or null.

jbenet added a commit that referenced this pull request Jul 3, 2015
daemon help docs for CORS
@jbenet jbenet merged commit 5203eac into ipfs:master Jul 3, 2015
@jbenet jbenet removed the backlog label Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants