Class 'ipinfo\ipinfo\Exception' not found

[dmitriy2018]

Executing getDetails with fake IP produces fatal error.

$ip = '34535'; $IPInfoClient->getDetails($ip);

Add use \Exception; into IPInfo.php

[rvalitov]

Add in PHPDoc that the function may rise an Exception

[scofield-ua]

@coderholic

[coderholic]

@jhtimmins

[jhtimmins]

@coderholic @scofield-ua I'll take a look later today and will fix/close this issue.

[jhtimmins]

@scofield-ua my apologies, I ran into some issues with my computer so I'm having trouble testing this, which may delay me a bit.

In the meantime, could you clarify why it's necessary to import Exceptions from multiple locations?

[scofield-ua]

@jhtimmins no problem, thanks.

I think the main idea of this issue is to fix the part where you're throwing global Exception class. For example here:

php/src/IPinfo.php

Lines 98 to 100 in 5b360e3

	throw new Exception('IPinfo request quota exceeded.');
	} elseif ($response->getStatusCode() >= 400) {
	throw new Exception('Exception: ' . json_encode([

Right now global Exception class is throwing in local namespace: ipinfo\ipinfo, which is causing fatal error.
Need to use throw new \Exception instead of throw new Exception, or just connect it at the beginning of the class.

In my project I'm currently have to catch Throwable exception.

Also, I think, instead of general global Exception class would be good to throw some custom named exception which is related only for IpInfo package, something like IpInfoException which you can use to throw any kind (or specific kind) of errors.

[rvalitov]

@jhtimmins, the comment of @scofield-ua is absolutely correct. That's what have been done in my PR #5
Additionally I added the correct information about the exceptions in PHPDoc.

[jhtimmins]

@scofield-ua Ah of course, yes that makes sense. I actually thought you submitted the PR with multiple exception types, which should have been directed at the PR author. Thanks for the info.

@rvalitov Could you explain this docblock, and why it includes two exception types?

     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \Exception

It doesn't look like \GuzzleHttp\Exception\GuzzleException will ever get thrown directly. Or am I missing something?

[rvalitov]

@jhtimmins
A function definition must include all uncatched exceptions. The exceptions may rise inside the function code or inside other functions that your original function calls. The functions that you call use Guzzle, and Guzzle functions throw \GuzzleHttp\Exception\GuzzleException. You don't catch exceptions from Guzzle therefore you pass them to the user. As a result you have to specify the \GuzzleHttp\Exception\GuzzleException in the PHPDoc.

[jhtimmins]

This was fixed in commit 6068f65.

I've added an IPinfoException class which will get returned instead of the base Exception class or the GuzzleException class.

[Acrash79]

😊

[UmanShahzad]

If 6068f65 does not resolve this issue, please let me know and we can reopen.