Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagjson.Decode support for self-delimited reading #374

Closed
petar opened this issue Mar 3, 2022 · 1 comment · Fixed by #435
Closed

dagjson.Decode support for self-delimited reading #374

petar opened this issue Mar 3, 2022 · 1 comment · Fixed by #435
Labels
P3 Low: Not priority right now

Comments

@petar
Copy link
Contributor

petar commented Mar 3, 2022

The current implementation of dagjson.Decode consumes whitespaces and EOF after a valid object.
This precludes repeated use on a single stream. Perhaps we could introduce a decoder option that does not consume any bytes after the terminal "}". This is generally the expected design for a decoder of any self-delimited format, in the sense that the self-delimitedness property is otherwise unusable in code. (E.g. json.Decode.)

@BigLep
Copy link

BigLep commented May 3, 2022

2022-05-03 triage conversation: this isn't something we're going to build into the core. This would need to be a special mode. Contributions welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants