Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitswap provider protocol id is incorrect #50

Closed
guseggert opened this issue Dec 6, 2022 · 1 comment · Fixed by #52
Closed

Bitswap provider protocol id is incorrect #50

guseggert opened this issue Dec 6, 2022 · 1 comment · Fixed by #52

Comments

@guseggert
Copy link
Contributor

$ curl -s https://dev.cid.contact/routing/v1/providers/bafykbzacedzugqdzfjjbd4pgsvwrpkfdpk7rzfrsgwqj2kehxv2ffjy2tlny6 | jq -r '.Providers[].Protocol'
transport-bitswap
transport-graphsync-filecoinv1

The correct protocol id for bitswap is bitswap. (These are intentionally different from multicodec names so that they can be versioned without having to add a new multicodec code.)

@willscott
Copy link
Member

noting that the thing the indexer gets from upstream is a multicodec code that it's translating here. do we really want custom logic to turn, specifically, transport-bitswap as named there into bitswap. because that seems like the path you're asking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants