Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Do not reload the page after applying suggested commits #1678

Open
cmbkla opened this issue Oct 17, 2019 · 0 comments
Open

Do not reload the page after applying suggested commits #1678

cmbkla opened this issue Oct 17, 2019 · 0 comments

Comments

@cmbkla
Copy link

cmbkla commented Oct 17, 2019

cc: [email protected]

Appreciate the "suggested change" functionality for code reviews, it's been a great help!

One thing about it, though, that can get frustrating is applying the suggested changes. I have to click them, one at a time, to apply them. Each time I do so, the entire page reloads. If I am in comments that are hidden by the "X Hidden Conversations" banner, after the refresh I have to click "Load More" to get back to where I was on the page, then click another suggested change, then go through it all again. It's tedious.

I see these as possible solutions:

#1 - add a way to commit multiple suggested changes at once. This will also prevent my commits from being flooded with messages about every single change.

#2 - do not reload the page after applying a suggested commit. If it is too technically difficult to repaint the page after the commit, due to the amount of other UI that could be changed, then move the whole thing off to a modal or separate page that doesn't need to be repainted so aggressively.

#3 - if #2 is simply not feasible, can you at least remember the "Load More" expansion state between refreshes, so the browser can move me back to the spot I was in after the page reload? Even if this is the only suggestion here that is applied, it would save quite a bit of clicks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant