Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Commit author email regression #1740

Open
bmon opened this issue Feb 24, 2020 · 3 comments
Open

Commit author email regression #1740

bmon opened this issue Feb 24, 2020 · 3 comments

Comments

@bmon
Copy link

bmon commented Feb 24, 2020

The email dropdown field which was added to solve #95 is no longer visible. It's still there, just hidden with display: none;. Please resolve this regression as it is important that we are able to select the correct email address to author squash/merge commits online!

@Lqp1
Copy link

Lqp1 commented Jun 30, 2020

Also encounter this issue, I'm unable to squash/merge with my organization's mail.
@bmon Do you know if forcing display: none; to other value allows us to select the right email as a temporary workaround?

EDIT: I tried and it's shown, but selecting another address does the merge with the wrong address anyway.

@bmon
Copy link
Author

bmon commented Jun 30, 2020

I raised a ticket to GitHub support about this issue. After a bit over a month, they replied that the committer email (note: not the commit author email which I asked about) is always set to a github email, and that the dropdown for the author email will not return for squash merges. I was pretty bummed after waiting 60 days to not get a reply to my actual question and I did not follow up.

FWIW they seem to have some system that makes a best guess for the right email, presumably based off the commits in the PR branch. I've only seen this problem a couple of times since opening this issue.

@Lqp1
Copy link

Lqp1 commented Jun 30, 2020

Thank you for your feedback.

Guess I have to do everything in CLI then :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@bmon @Lqp1 and others