Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate users #105

Closed
NicolasLM opened this issue Jul 17, 2014 · 4 comments
Closed

Authenticate users #105

NicolasLM opened this issue Jul 17, 2014 · 4 comments
Labels
feature needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed
Milestone

Comments

@NicolasLM
Copy link

The idea is to allow only authenticated users to post comments.

A global work-flow could be:

  • Provide an endpoint where users can sign in
  • Server side the user is authenticated (query in DB, OAuth... this should be extensible)
  • A cookie is issued with the encrypted user name and timeout.
  • When a user posts a comment the cookie is checked and the user name is taken from it instead of read from the sent JSON

Using an encrypted cookie removes the need of implementing sessions server side.

One thing to think about is to remove the user name, email and website fields from the showed form.

Also providing a simple way to know if the user is already authenticated or not.

@posativ posativ added this to the 0.10 milestone Aug 18, 2014
@posativ posativ modified the milestones: 0.10, 1.0 Nov 25, 2014
@tasmo
Copy link

tasmo commented Mar 20, 2015

+1

@dashohoxha
Copy link

I think that authentication is important. I want only the registered users (in my application) to be able to post comments. But I don't want a situation where the users first login to my application, and then they have to login again to the commenting system in order to be able to post.

So I would suggest that the first two points above (authentication of the user) can be done by the application. When it comes to generating a cookie or token, the application contacts ISSO (via its API), sends the data of the user (name, email, etc.), and receives an encrypted cookie/token.

Then this cookie/token is sent together with the comment that is to be posted, and guaranties to ISSO that the user is authenticated, and also provides to it the user data (name, email, etc. by decrypting it).

Encryption must ensure that such a token cannot be faked or forged by a spammer.

@nogweii
Copy link

nogweii commented Nov 27, 2016

See also, #240.

@ix5 ix5 added feature needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed labels Feb 10, 2022
@ix5
Copy link
Member

ix5 commented Feb 24, 2022

Most recent activity in #240. #261 partially solves this.

Closing in favour of those linked issues/PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed
Projects
None yet
Development

No branches or pull requests

6 participants