Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: now applying the same verifications when creating or editing comments #1038

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented Sep 30, 2024

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • [-] (If docs changes needed:) I have updated the documentation accordingly.
  • [-] I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

The same API.verify() method is called when creating a new comment or editing existing ones.
Previously, API.verify() was only called during comment creation.

Why is this necessary?

In order to face spammers, I use a custom API.verify() method on my isso instance to forbids URLs in comments
( while waiting for some other spam-control mechanism to be implemented in isso maybe on day, cf. #941 )

On my instance, I have seen spammers creating empty comments and then editing them to insert URLs.

This PR ensures that the same rules defined in API.verify() are applied during all the "life cycle" of a comment.

@jelmer jelmer merged commit 4672872 into isso-comments:master Sep 30, 2024
17 of 18 checks passed
@ix5 ix5 added server (Python) server code improvement Not a new feature, but makes Isso more pleasant to use labels Oct 2, 2024
@ix5 ix5 added this to the 0.13.1 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a new feature, but makes Isso more pleasant to use server (Python) server code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants