Fix: now applying the same verifications when creating or editing comments #1038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rst
because this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
The same
API.verify()
method is called when creating a new comment or editing existing ones.Previously,
API.verify()
was only called during comment creation.Why is this necessary?
In order to face spammers, I use a custom
API.verify()
method on my isso instance to forbids URLs in comments( while waiting for some other spam-control mechanism to be implemented in isso maybe on day, cf. #941 )
On my instance, I have seen spammers creating empty comments and then editing them to insert URLs.
This PR ensures that the same rules defined in
API.verify()
are applied during all the "life cycle" of a comment.