Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Set TOX_ENV to use artifacts from nodejs build instead of building inside Python container (fixes #759) #760

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Dockerfile: Set TOX_ENV to use artifacts from nodejs build instead of building inside Python container (fixes #759) #760

merged 1 commit into from
Jan 15, 2022
+1 −0

Commits on Jan 15, 2022

  1. Dockerfile: Avoid rebuilding js in python step 

    Set `TOX_ENV` to avoid re-running the javascript
generation step that has already been handled by
the nodejs `jsBuilder` step.

This causes the `NpmBuildCommand` inside
`setup.py` to abort early.

This fixes the Docker build as previously it would
fail to compile javascript in a pure-python docker
container.

Fix isso-comments#759
    @alexandru
    alexandru committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    923a6b2 View commit details
    Browse the repository at this point in the history