Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .GetRevisions() option #297

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Add .GetRevisions() option #297

merged 3 commits into from
Aug 15, 2023

Conversation

rasa
Copy link
Contributor

@rasa rasa commented Aug 4, 2023

No description provided.

@rasa
Copy link
Contributor Author

rasa commented Aug 4, 2023

The code works, but I'm unable to figure out how to install the extras_require packages to get the tests to run.

@shcheklein
Copy link
Member

@rasa thanks! pre-commit hook fails, please check the output, run linters locally to fix it. After that we can run the tests on CI.

The code works, but I'm unable to figure out how to install the extras_require packages to get the tests to run.

Has to be something like (in a virtualenv):

pip install -e ".[tests]"

@rasa rasa temporarily deployed to external August 5, 2023 00:55 — with GitHub Actions Inactive
@rasa
Copy link
Contributor Author

rasa commented Aug 5, 2023

pip install -e ".[tests]"

Thanks! I tried
pip install -e ".[extras]"
before, but it didn't work.
I just ran
pip install -e ".[tests]"
but then I needed to run
pip install -e ".[fsspec]"
as fsspec and appdirs needed to be installed.

If I had foresight, I would have checked here where I would have found python -m pip install -e '.[fsspec, tests]'

When I run the tests, the first Google Signin works, but the next two just spin forever at

pydrive2/test/test_apiattr.py F                                                                                                                                                      [  2%]
pydrive2/test/test_drive.py E                                                                                                                                                        [  4%]
pydrive2/test/test_file.py EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEsEEEE                                                                                                                  [ 58%]
pydrive2/test/test_filelist.py EEEE                                                                                                                                                  [ 63%]
pydrive2/test/test_fs.py .FFEEEEEEEEEEEE                                                                                                                                             [ 83%]
pydrive2/test/test_oauth.py .F

@rasa rasa temporarily deployed to external August 5, 2023 15:16 — with GitHub Actions Inactive
@shcheklein
Copy link
Member

@rasa looks like also Python 3.8 / 3.9 tests fail. Please check the logs above.

@rasa
Copy link
Contributor Author

rasa commented Aug 5, 2023

@rasa looks like also Python 3.8 / 3.9 tests fail. Please check the logs above.

The logs show the same error that occurred on July 10 in these logs so I don't think the issue is with my PR. The July 5 run was the last to succeed.

Edit: Perhaps we need to pin the specific Python version? I can look into that in a few hours.

@shcheklein
Copy link
Member

Yes, you are right, most likely PyInstaller got updated actually. We'll check that.

@shcheklein shcheklein merged commit c473d63 into iterative:main Aug 15, 2023
@shcheklein
Copy link
Member

@rasa thanks! I've merged it and triggered the release process.

@rasa rasa deleted the add_revisions branch August 15, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants