Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll-to-text fragment does not work #4573

Open
skshetry opened this issue May 26, 2023 · 6 comments
Open

scroll-to-text fragment does not work #4573

skshetry opened this issue May 26, 2023 · 6 comments
Assignees
Labels
A: website Area: website p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working.

Comments

@skshetry
Copy link
Member

Report

dvc.org does not auto scroll to the text fragment.

For example: this link does highlight, but it does not navigate automatically navigate to that text:
https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#:~:text=list%20of%20metrics-,contains%20one%20or%20more%20paths%20to,-metrics%20files.%20Here%27s

https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#:~:text=list%20of%20metrics-,contains%20one%20or%20more%20paths%20to,-metrics%20files.%20Here%27s

Note that scroll-to-text fragment is not yet available yet on Firefox, and only available on Safari 16.1 or greater.

Also see https://web.dev/text-fragments/.

Screencast.from.2023-05-26.16-22-59.webm
@shcheklein shcheklein added the p1-important Active priorities to deal within next sprints label Jul 8, 2023
@shcheklein
Copy link
Member

I'm hitting the same issue:

Screen.Recording.2023-07-08.at.4.14.07.PM.mov

@yathomasi @julieg18 could you please take a look when you have time? I think it breaks user experience significantly.

@shcheklein shcheklein added A: website Area: website 🐛 type: bug Something isn't working. labels Jul 8, 2023
@skshetry
Copy link
Member Author

skshetry commented Jul 9, 2023

@shcheklein, that link works for me in Firefox, but not in Chromium for some reason.

But this issue is a bit different. scroll-to-text fragment is a new spec, you can read more about it here: https://web.dev/text-fragments/, while the one you have is scrolling to a specific anchor.

@dberenbaum
Copy link
Contributor

Is this still a priority @shcheklein?

@shcheklein shcheklein removed the p1-important Active priorities to deal within next sprints label Jan 4, 2024
@shcheklein
Copy link
Member

It's annoying issue (e.g. you send a link someone and they can't open it to the point that you expect them to read). Among other issues related to the engine I think this is an important one.

@shcheklein shcheklein added the p1-important Active priorities to deal within next sprints label Jan 4, 2024
@yathomasi
Copy link
Contributor

Text fragments are also working for me. Overall, It's the scroll to section, that's not working properly.

Screen.Recording.2024-01-05.at.12.41.17.mov

AFAIR, we have a legacy code that overrides the default scroll logic, which is never a good idea, but it must be there because that might have been the only option at that moment.

I remember stumbling on that code at some point and didn't do a deep dive as it would need quite a refactoring. Anyway, I can prioritize and take this current sprint.

@yathomasi yathomasi self-assigned this Jan 5, 2024
@skshetry
Copy link
Member Author

skshetry commented Jan 5, 2024

Highlighting seems to be working, but scrolling does not work reliably for text fragments either. Maybe same issue as with anchors.

Screen.Recording.2024-01-05.at.13.20.10.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

4 participants