Update footer design #2495
Update footer design #2495
Conversation
* delete IconSet component * add youtube, linkedin, and discord icons to IconSet component * add cml, studio, and iterative svg images to img * update img/logo.svg
|
|
||
| .companyDescription { | ||
| @media (--xs-scr) { | ||
| font-size: 14px; |
There was a problem hiding this comment.
As I did with cml.dev and iterative.ai, I increased the company description from 12px to 14px
| @mixin active; | ||
| @mixin hover; | ||
|
|
||
| font-weight: 800; |
There was a problem hiding this comment.
While the font-weight says 800, I'm pretty sure it's 600 since that appears to be the largest weight our font has:
|
To fix the codeclimate issues, I can place all of the Footer link info into a |
Sounds like a good idea to me! |
|
| import styles from './styles.module.css' | ||
|
|
||
| const docsPage = getFirstPage() | ||
|
|
||
| const LayoutFooter: React.FC<Required<ILayoutModifiable>> = ({ modifiers }) => ( | ||
| interface IFooterLinkData { |
There was a problem hiding this comment.
I'm pretty new to TypeScript, please let me know if my typescript code can be improved!
| } | ||
| ] | ||
|
|
||
| const FooterLists: React.FC = () => ( |
There was a problem hiding this comment.
Should I move these functions(FooterLists and FooterSocialIcons) to a folder inside LayoutFooter?
There was a problem hiding this comment.
Sounds like a sensible refactor, but not necessary before merge at least.
|
Looks great, nice work! |
svgwith theIconSetcomponent).githubandtwittersvgs that were in theIconSetcomponent. The only difference as far as I can tell is that thegithubis smaller.)logo.svgis only used in the nav bar and the footer.)