Next header iteration #2555
Merged
Next header iteration #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* decrease font size for Nav link items * add "Other Tools" to HamburgerMenu
julieg18
commented
Jun 10, 2021
| @@ -15,7 +15,7 @@ | |||
| z-index: 1; | |||
| padding: 16px 24px; | |||
| font-weight: 500; | |||
| font-size: 18px; | |||
| font-size: 16px; | |||
There was a problem hiding this comment.
I went ahead and lowered the font for the "Get Started" button. If it didn't need to be decreased as well, let me know!
julieg18
commented
Jun 10, 2021
| @@ -58,7 +58,7 @@ | |||
| position: fixed; | |||
| display: block; | |||
| z-index: 2; | |||
| top: 78px; | |||
| top: var(--layout-header-height); | |||
There was a problem hiding this comment.
What the documentation page looks like on dvc.org:
What it looks like in pull request:
rogermparent
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HamburgerMenu16pxand 400 in nav bar linkstopin the documentation side bar was off due to the nav bar height changing in the last nav iterationFixes #2543