Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyright and licensing information #53

Closed
christian-schlichtherle opened this issue Sep 11, 2020 · 2 comments
Closed

Fix copyright and licensing information #53

christian-schlichtherle opened this issue Sep 11, 2020 · 2 comments
Milestone

Comments

@christian-schlichtherle
Copy link
Contributor

I'm new to this repo, so please bear with me if I'm getting something wrong.

Currently, the copyright and license header looks like this:

<!--
  ~ Licensed to the Koordinierungsstelle für IT-Standards (KoSIT) under
  ~ one or more contributor license agreements. See the NOTICE file
  ~ distributed with this work for additional information
  ~ regarding copyright ownership.  KoSIT licenses this file
  ~ to you under the Apache License, Version 2.0 (the
  ~ "License"); you may not use this file except in compliance
  ~ with the License. You may obtain a copy of the License at
  ~
  ~ http://www.apache.org/licenses/LICENSE-2.0
  ~
  ~ Unless required by applicable law or agreed to in writing,
  ~ software distributed under the License is distributed on an
  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  ~ KIND, either express or implied. See the License for the
  ~ specific language governing permissions and limitations
  ~ under the License.
  -->

I think this is misleading, if not wrong:

First, there is no copyright claim at all. I suppose the "Koordinierungsstelle für IT-Standards (KoSIT)" is the copyright owner, right? Then the first line should actually have a copyright claim like this:

Copyright © 2019 - 2020 by Koordinierungsstelle für IT-Standards (KoSIT)

where 2019 is the year of inception and 2020 the year of the last edit. With no copyright claim at all however, according to US legislation (and maybe in other countries, too), this would not be copyrighted material. I'm no lawyer, though, so I maybe wrong.

Next, I think the meaning of the first sentence is that KoSIT is the actual copyright owner and licenses this material under the terms and conditions of the ASL 2, right? Then the second word, which is "to", should be replaced with "by". In the current text however, KoSIT is licensing their own work to themselves. :-)

Last, but not least, you could swap the license boiler plate with the recommended form, which you can find at the very end of this page: http://www.apache.org/licenses/LICENSE-2.0

@apenski
Copy link
Collaborator

apenski commented Sep 14, 2020

Thanks for reporting this. Actually intention is clear, I think. But the implementation of the ASL here should meet the formal requirements. I pushed a change to branch.

@rkottmann can you please review this

rkottmann pushed a commit that referenced this issue Sep 14, 2020
- remove implementation instructions
- add acronym KoSIT
rkottmann pushed a commit that referenced this issue Sep 14, 2020
rkottmann pushed a commit that referenced this issue Oct 2, 2020
#53 Fix copyright and licensing information

See merge request kosit/validator!35
@apenski apenski added this to the 1.3.2 milestone Oct 2, 2020
@apenski
Copy link
Collaborator

apenski commented Oct 2, 2020

fixed in master

@apenski apenski closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants