Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable month names in configuration file #5

Closed
ckunki opened this issue Jun 3, 2021 · 1 comment · Fixed by #18
Closed

Enable month names in configuration file #5

ckunki opened this issue Jun 3, 2021 · 1 comment · Fixed by #18
Labels
enhancement New feature or request

Comments

@ckunki
Copy link
Collaborator

ckunki commented Jun 3, 2021 •
edited
Loading

Currently months are identified by their number, e.g. 12 for December.

holiday float 4 SUN before 12 24 1. Advent

Request: Support months to be identified alternatively by their names, e.g. "December".

holiday float 4 SUN before December 24 1. Advent
@kaklakariada
Copy link
Contributor

Good idea, this improves readability!

@ckunki ckunki added the enhancement New feature or request label Jun 4, 2021
@ckunki ckunki linked a pull request Jun 5, 2021 that will close this issue
5 Support month names #18
Merged
@ckunki ckunki closed this as completed in #18 Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5 Support month names itsallcode/holiday-calculator
2 participants
@kaklakariada @ckunki