Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PmSmart: Enable skip handling comments #158

Closed
ckunki opened this issue May 23, 2021 · 5 comments · Fixed by #160
Closed

PmSmart: Enable skip handling comments #158

ckunki opened this issue May 23, 2021 · 5 comments · Fixed by #160
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ckunki
Copy link
Contributor

ckunki commented May 23, 2021

Entering comments via web UI takes quite some time.

If a specific user does not use comments for recorded times at all, then WR should enable this user to configure WR to ignore all comments.

If WR ignores comments then web UI can skip transfer of comments and hence will execute faster.

@kaklakariada kaklakariada added the enhancement New feature or request label May 24, 2021
@ckunki
Copy link
Contributor Author

ckunki commented May 28, 2021

How about a property in .whiterabbit.properties?

pmsmart.transfer.comments = false

@kaklakariada
Copy link
Contributor

Sounds good to me!

@ckunki
Copy link
Contributor Author

ckunki commented May 28, 2021

Is this a mandatory value?

Interface PluginConfiguration, provides only the possibility to ask the configuration for mandatory values, but not for optional ones. And in my eyes pmsmart.transfer.comments would rather be an optional configuration.

Two options:

  1. enhance interface to contain a method also for optional values or create an additional interface
  2. declare option pmsmart.transfer.comments as mandatory in spite of my gut feelings

@ckunki ckunki linked a pull request May 28, 2021 that will close this issue
@kaklakariada
Copy link
Contributor

Until now there was no need for optional parameters ;-). Please add a method to PluginConfiguration, returning an Optional.

@ckunki
Copy link
Contributor Author

ckunki commented May 29, 2021

I added a method for optional parameters.

@ckunki ckunki self-assigned this May 30, 2021
@kaklakariada kaklakariada added this to the Version 1.7.0 milestone May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants