Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicated code in plugins #182

Open
ckunki opened this issue Jun 6, 2021 · 2 comments
Open

Avoid duplicated code in plugins #182

ckunki opened this issue Jun 6, 2021 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@ckunki
Copy link
Contributor

ckunki commented Jun 6, 2021

Sonarqube reports duplicated code in plugins csv and holiday-calculator.

Proposal: Create abstract class GenericPlugin<T>.

Open: Where to put class? In api would be fine.
logic would require additional dependencies for plugins.
@ckunki ckunki added the dependencies Pull requests that update a dependency file label Jun 6, 2021
@ckunki
Copy link
Contributor Author

ckunki commented Jun 6, 2021

What do you think, @kaklakariada ?

@kaklakariada
Copy link
Contributor

I also thought about this. The API project is the easiest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaklakariada @ckunki