Add the ability to initialise a DownView using a custom template bundle #27
Conversation
There was a problem hiding this comment.
Looks good overall, thanks @tonyarnold
One request: mind adding a quick test for this similar to the ones in https://github.com/iwasrobbed/Down/blob/master/Tests/DownViewTests.swift ?
|
Not at all! I'll add a test when I'm next at my Mac 👍 |
|
Do the test targets work for you? I can't get either the iOS or the macOS targets to build, let alone run. |
|
@tonyarnold I haven't tested locally, but they ran successfully as part of this PR |
|
Changes Unknown when pulling db460de on tonyarnold:feature/custom-template-bundles into ** on iwasrobbed:master**. |
tonyarnold
force-pushed
the
feature/custom-template-bundles
branch
from
db460de to
b043c74
Compare
|
@iwasrobbed I've added a single test (along with a test bundle fixture) in addc235. Let me know if you need more! |
|
Looks great, thanks again @tonyarnold ! |
|
You're welcome - thanks for the great library! |
|
Changes Unknown when pulling b043c74 on tonyarnold:feature/custom-template-bundles into ** on iwasrobbed:master**. |
|
Changes Unknown when pulling addc235 on tonyarnold:feature/custom-template-bundles into ** on iwasrobbed:master**. |
This PR introduces an extra optional parameter when initialising
DownViewthat allows the caller to specify a custom template bundle.