Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NoiseLib.glslib #2188

Closed
yaRnMcDonuts opened this issue Jan 31, 2024 · 2 comments · Fixed by #2189
Closed

Move NoiseLib.glslib #2188

yaRnMcDonuts opened this issue Jan 31, 2024 · 2 comments · Fixed by #2189
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Milestone

Comments

@yaRnMcDonuts
Copy link
Member

I appear to have uploaded a file called "NoiseLib.glslib" to the "jme3-terrain" module when I made the PR for PBR terrain shaders. Currently that glslib is only referenced by PBRTerrain.frag and AdvancedPBRTerrain.frag, so I would also need to update those as well.

This glslib contains all of the standard 2d and 3d noise equations for basic noise as well as perlin noise, and could (hopefully) be updated in the future if any jme contributors want to add more noise equations.

(this file: https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-terrain/src/main/resources/Common/MatDefs/Terrain/NoiseLib.glsllib)

In hindsight, I think this should have probably been uploaded to jme3-core in the Common/ShaderLib/ directory so that any jme devs that want to use noise can have easy access to these standard noise equations

Would it be okay if I make a PR to move NoiseLib.glsllib to jme3-core with the other .glslib files? That way, users who are working on shaders that require noise will not have to include the whole jme3-terrain module.

@stephengold
Copy link
Member

Sounds good to me.

@scenemax3d scenemax3d added this to the v3.7.0 milestone Feb 1, 2024
@stephengold stephengold linked a pull request Oct 22, 2024 that will close this issue
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Oct 22, 2024
@stephengold
Copy link
Member

It seems this was solved in "master" branch before the v3.7 split. I'm unsure why it wasn't closed at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants