Add support for ptpython config and history files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the official/upstream way of finding the config and history file, since ~/.ptpython/config.py is deprecated. It also uses the global ones, though it can be easily extended to support per project config and history. But that's for a rainy day. Fixes jacquerie#7 and jacquerie#13.
|
I'm ok for a global one for now. By global, you mean shared by all ptpython instances ? not only flask ones ? |
|
Global as in all ptpython instances. It's basically copied from the ptpython cli. |
azmeuk
approved these changes
Aug 7, 2020
|
Hi @jacquerie. Is there a chance you might review this soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the official/upstream way of finding the config and history file, since ~/.ptpython/config.py is deprecated. It also uses the global ones, though it can be easily extended to support per project config and history. But that's for a rainy day, unless @bersace want's to extend this with his change?
Fixes #7 and fixes #13.